search

scrapinghub / exporters

Exporters is an extensible export pipeline library that supports filter, transform and several sources and destinations
BSD 3-Clause "New" or "Revised" License
40 stars 10 forks source link

Update decompression parameters in S3 Reader #279

Closed serhiy-yasko closed 8 years ago

serhiy-yasko commented 8 years ago

An attempt to address https://staging.scrapinghub.com/p/28865/job/2/708/log?line=106.

bbotella commented 8 years ago

Adding 32 allows for automatic detection. Good try. I'll merge that and we'll try it.

eliasdorneles commented 8 years ago

could we have this number in a nice variable name? it's like a magic number in the code. :)

bbotella commented 8 years ago

Well, TBH, it's like a magic number :joy:

Check this detailed answer: http://stackoverflow.com/questions/3122145/zlib-error-error-3-while-decompressing-incorrect-header-check/22310760#22310760