search

scrapinghub / exporters

Exporters is an extensible export pipeline library that supports filter, transform and several sources and destinations
BSD 3-Clause "New" or "Revised" License
40 stars 10 forks source link

Adds dicttoxml to lazy requirements instead of main requirements (close #306) #307

Closed bbotella closed 8 years ago

bbotella commented 8 years ago

Handling https://github.com/scrapinghub/exporters/issues/306

eliasdorneles commented 8 years ago

Hm, the import in compression.py should be changed to be dynamic too, replacing the hardcoded with something like this at the end of the file:

try:
    from bz2file import BZ2File
except ImportError:
    pass
else:
    FILE_COMPRESSION['bz2'] = lambda path: BZ2File(path, 'a')
bbotella commented 8 years ago

Right. Will do it.

eliasdorneles commented 8 years ago

Btw, tip: if you put "close #ISSUE_ID" in the PR title, it will close the issue automatically when merged :)

eliasdorneles commented 8 years ago

@bbotella kinda miss nitpicking your PRs! :laughing:

eliasdorneles commented 8 years ago

Neat, will merge when build finishes! Thanks @bbotella ! :heart: