search

scrapinghub / exporters

Exporters is an extensible export pipeline library that supports filter, transform and several sources and destinations
BSD 3-Clause "New" or "Revised" License
40 stars 10 forks source link

current code for saving s3 key metadata for multipart uploads doesn't work #333

Closed kalessin closed 8 years ago

kalessin commented 8 years ago

current code for saving s3 key metadata for multipart uploads doesn't work. Fixed using the correct way, according to boto documentation

http://boto.readthedocs.io/en/latest/ref/s3.html#boto.s3.bucket.Bucket.initiate_multipart_upload

kalessin commented 8 years ago

some tests are failing but has no relation with my change. Fail is on gdrive test, not s3.

kalessin commented 8 years ago

I also removed a method (_set_key_metadata() ) that is not used anywhere

dvdbng commented 8 years ago

Thanks! :+1:

kalessin commented 8 years ago

thank you!