search

scrapinghub / frontera

A scalable frontier for web crawlers
BSD 3-Clause "New" or "Revised" License
1.29k stars 216 forks source link

Crash on closing redis backend, missing 'force_clear' argument #347

Closed vfcosta closed 6 years ago

vfcosta commented 6 years ago

Frontera is failing with the following error when using add_seeds with redis as the backend: TypeError: flush() missing 1 required positional argument: 'force_clear'

codecov[bot] commented 6 years ago

Codecov Report

Merging #347 into master will increase coverage by 0.28%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
+ Coverage   59.95%   60.23%   +0.28%     
==========================================
  Files          78       78              
  Lines        6143     6144       +1     
  Branches      809      809              
==========================================
+ Hits         3683     3701      +18     
+ Misses       2284     2269      -15     
+ Partials      176      174       -2
Impacted Files Coverage Δ
frontera/settings/default_settings.py 100% <100%> (ø) :arrow_up:
...rontera/contrib/backends/redis_backend/__init__.py 83.84% <100%> (+5.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8830ce2...bd3211b. Read the comment docs.