search

scrapinghub / frontera

A scalable frontier for web crawlers
BSD 3-Clause "New" or "Revised" License
1.29k stars 216 forks source link

I have done some workaround across implementing ActiveMq to the messagebus so would like to contribute #350

Open amitsing89 opened 5 years ago

amitsing89 commented 5 years ago

Hi,

I have started once to integrate the activeMq in the messagebus so i would like to add that to the repository, so if you can allow kme to contribute then it would be helpful to add a new component

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (exception-dbw@dec0e02). Click here to learn what that means. The diff coverage is 57.89%.

Impacted file tree graph

@@               Coverage Diff               @@
##             exception-dbw    #350   +/-   ##
===============================================
  Coverage                 ?   60.3%           
===============================================
  Files                    ?      78           
  Lines                    ?    6145           
  Branches                 ?     809           
===============================================
  Hits                     ?    3706           
  Misses                   ?    2264           
  Partials                 ?     175
Impacted Files Coverage Δ
frontera/utils/twisted_helpers.py 78% <ø> (ø)
frontera/utils/graphs/data.py 81.81% <ø> (ø)
frontera/contrib/backends/remote/messagebus.py 80% <0%> (ø)
frontera/contrib/scrapy/messagebus_stats.py 0% <0%> (ø)
frontera/utils/s3.py 0% <0%> (ø)
frontera/strategy/depth.py 0% <0%> (ø)
frontera/strategy/discovery/__init__.py 0% <0%> (ø)
frontera/contrib/scrapy/schedulers/recording.py 0% <0%> (ø)
frontera/strategy/discovery/sitemap.py 0% <0%> (ø)
...ontera/contrib/messagebus/kafka/offsets_fetcher.py 14.89% <0%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dec0e02...84f9e10. Read the comment docs.

sibiryakov commented 5 years ago

Hey @amitsing89 , I think you should rebase it to latest master, it seems to me your code is based on some outdated version.

sibiryakov commented 5 years ago

Currently, it's extremely hard to review because of enormous amount of unrelated changes.

amitsing89 commented 5 years ago

i will update it and will try to start it again

Gallaecio commented 5 years ago

@amitsing89 You should rebase your changes on top of the latest master as suggested. Have you used Git rebase before? Have you added the main repository as an upstream remote in your local clone of your fork?

github-advanced-security[bot] commented 4 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.