scrapinghub / frontera

A scalable frontier for web crawlers
BSD 3-Clause "New" or "Revised" License
1.29k stars 215 forks source link

Bump to Python 3.6 + 3.7 #379

Closed suzil closed 4 years ago

suzil commented 4 years ago
codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@02326d2). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #379   +/-   ##
=========================================
  Coverage          ?   60.26%           
=========================================
  Files             ?       78           
  Lines             ?     6145           
  Branches          ?      809           
=========================================
  Hits              ?     3703           
  Misses            ?     2267           
  Partials          ?      175
Impacted Files Coverage Δ
frontera/contrib/backends/hbase/utils.py 68.75% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 02326d2...ebb4d32. Read the comment docs.

sibiryakov commented 4 years ago

Hey, thank you for that. I think it also makes sense to add thriftpy2 to hbase section, so the ones who will be using frontera with hbase will get the right package. Have you checked the compatibility of happybase with thriftpy2 ?

suzil commented 4 years ago

thriftpy2 is fully compatible with thriftpy according to their docs (and they are in the same organization), so it should be OK. I have included thriftpy2 additionally as a requirement of hbase.

sibiryakov commented 4 years ago

okay! merging