scrapinghub / js2xml

Convert Javascript code to an XML document
MIT License
186 stars 23 forks source link

Python3 support #11

Closed sgornick closed 8 years ago

sgornick commented 8 years ago

Will js2xml be getting support for Python3?

  File "js2xml/lexer.py", line 413
    print 'Illegal character %r at %s:%s after %s' % (
redapple commented 8 years ago

@sgornick , I've started #12. If you can provide feedback, that would be much appreciated.

sgornick commented 8 years ago

@redapple, I pulled the branch py3-support and it now worked fine for me under both python3 (3.4), and python (2.7).

Do I close this issue?

redapple commented 8 years ago

@sgornick , thanks a ton for the feedback on the py3 branch. Once #12 is merged into master, I'll close this one.

redapple commented 8 years ago

https://github.com/redapple/js2xml/pull/12 got merged.