scrapinghub / js2xml

Convert Javascript code to an XML document
MIT License
186 stars 23 forks source link

Move helpers to a js2xml.utils submodule #26

Closed redapple closed 7 years ago

redapple commented 7 years ago

js2xlm.jsonlike is a misleading name for what the submodule provides:

This very change moves the functionality of js2xml.jsonlike to its own submodule js2xml.utils.objects.

In there, you can still get out Python dicts and lists, but also "simple" JavaScript built-in objects:

You have 3 main methods:

redapple commented 7 years ago

Hey @rolando, I'm introducing a js2xml.utils submodule. Would your helpers in #22 fit?

codecov-io commented 7 years ago

Codecov Report

Merging #26 into master will decrease coverage by 0.11%. The diff coverage is 93.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   90.54%   90.43%   -0.12%     
==========================================
  Files           9       10       +1     
  Lines         656      669      +13     
==========================================
+ Hits          594      605      +11     
- Misses         62       64       +2
Impacted Files Coverage Δ
js2xml/jsonlike.py 100% <100%> (+4.34%) :arrow_up:
js2xml/utils/objects.py 92.3% <92.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c49cd3...11d3b21. Read the comment docs.

rmax commented 7 years ago

@redapple Yes, sounds good to me.