redapple commented 7 years ago

Fixes #22

Hi @rolando, I've added your code to js2xml.utils.vars + some tests. Let me know what you think.

codecov-io commented 7 years ago

Codecov Report

Merging #27 into master will decrease coverage by 2.61%. The diff coverage is 62.85%.

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   90.43%   87.82%   -2.62%     
==========================================
  Files          10       11       +1     
  Lines         669      739      +70     
==========================================
+ Hits          605      649      +44     
- Misses         64       90      +26

Impacted Files	Coverage Δ
js2xml/utils/vars.py	`62.85% <62.85%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 752c009...58c0869. Read the comment docs.

redapple commented 7 years ago

hi @rmax, would you have some time to review this? Thanks.

rmax commented 7 years ago

Nice, thanks for taking care of this.

scrapinghub / js2xml

Add @rolando 's helpers #27

Codecov Report