search

scrapinghub / js2xml

Convert Javascript code to an XML document
MIT License
186 stars 23 forks source link

Opening in U mode has been deprecated and removed in Python 3.10. #38

Closed tirkarthi closed 4 years ago

tirkarthi commented 4 years ago

Fixes #37

codecov[bot] commented 4 years ago

Codecov Report

Merging #38 into master will increase coverage by 2.18%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   87.88%   90.06%   +2.18%     
==========================================
  Files          11       11              
  Lines         743      745       +2     
==========================================
+ Hits          653      671      +18     
+ Misses         90       74      -16
Impacted Files Coverage Δ
js2xml/__main__.py 0.00% <0.00%> (ø)
js2xml/yacctab.py 100.00% <0.00%> (+100.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d01b79e...e7f9e43. Read the comment docs.

tirkarthi commented 4 years ago

Sorry about that I committed from GitHub UI and force pushed the pep8 change without pulling the changes locally. I applied back the changes.

tirkarthi commented 4 years ago

Thanks @elacuesta for the review