search

scrapinghub / js2xml

Convert Javascript code to an XML document
MIT License
186 stars 23 forks source link

Cover js2xml 0.4.0 in the release notes #40

Closed Gallaecio closed 4 years ago

Gallaecio commented 4 years ago

Because our major version is still 0, I bumped the minor version instead, in line with semantic versioning. Caret requirements in poetry, for example, take that into account, and treat minor versions while major is 0 similarly to how they treat major versions once major is 1+.

codecov[bot] commented 4 years ago

Codecov Report

Merging #40 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   89.30%   89.30%           
=======================================
  Files           6        6           
  Lines         533      533           
=======================================
  Hits          476      476           
  Misses         57       57

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 119d926...0a69a72. Read the comment docs.

Gallaecio commented 4 years ago

I think it'd be nice to add some monospace bits into it

To “calmjs.parse” and “slimit”?

elacuesta commented 4 years ago

To “calmjs.parse” and “slimit”?

Precisely. In any case, not a deal breaker, I just like monospace text. Sorry for the delay.