scrapinghub / number-parser

Parse numbers written in natural language

BSD 3-Clause "New" or "Revised" License

108 stars 23 forks source link

new parse_fraction function for simple fractions added with test data #60

Closed Manish-210 closed 3 years ago

Manish-210 commented 3 years ago

See issue #59 parse_fraction function handles basic fraction. Some test data has also been added.

Resolves #59

codecov[bot] commented 3 years ago

Codecov Report

Merging #60 (4cebc90) into master (18aa853) will increase coverage by 0.07%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   98.70%   98.78%   +0.07%     
==========================================
  Files          85       86       +1     
  Lines         309      328      +19     
  Branches       55       60       +5     
==========================================
+ Hits          305      324      +19     
  Misses          1        1              
  Partials        3        3

Impacted Files	Coverage Δ
number_parser/__init__.py	`100.00% <100.00%> (ø)`
number_parser/parser.py	`98.35% <100.00%> (+0.13%)`	:arrow_up:

Manish-210 commented 3 years ago

Thanks, I have included a few examples in the README

Manish-210 commented 3 years ago

Renaming the sections is good, also I have changed the introductory paragraph a little in the usage section. Let me know if it's ok or not.

Manish-210 commented 3 years ago

Will there be any other checks before merging this pull request?

Gallaecio commented 3 years ago

Let’s wait for @noviluni to find some time to review this as well. If he finds the changes OK as well, we’ll merge.

Manish-210 commented 3 years ago

Thanks, @noviluni, let me know any other changes.

noviluni commented 3 years ago

Thanks @Manish-210! :smile: