codecov[bot]
commented
2 years ago Codecov Report
Merging #74 (4fd5e95) into master (8367865) will increase coverage by
0.37%. The diff coverage is96.15%.
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 98.78% 99.15% +0.37%
==========================================
Files 86 86
Lines 328 356 +28
Branches 61 69 +8
==========================================
+ Hits 324 353 +29
+ Misses 1 0 -1
Partials 3 3 | Impacted Files | Coverage Δ | |
|---|---|---|
| number_parser/parser.py | 98.89% <96.15%> (+0.53%) |
:arrow_up: |
Fixes #5 Ignore parameter right now is for only the parse function(can also implement for parse_number and parse_ordinal once reviewed) Ignoring parameters present in the ignore list and not parsing it to a number and simply adding it as it is to the output string and then keep building further. Also have added few test cases in test_number_parsing for the same. Let me know what you think and can update the Readme once its approved.