search

scrapinghub / portia

Visual scraping for Scrapy
BSD 3-Clause "New" or "Revised" License
9.28k stars 1.41k forks source link

Add input box to create project #670

Closed ruairif closed 7 years ago

ruairif commented 7 years ago

create_project Fix problem with project creation

michalmo commented 7 years ago

Maybe this should be in the reverse order. Choose a project or create a new one.

ruairif commented 7 years ago

when it's done this way both options are easily available without needing to scroll

eng1neer commented 7 years ago

When creating a project with the name "example.com" it gets added to the project list but an alert flashes Project with id 'undefined' not found. I guess that dot symbol is not allowed in project name?

sagelliv commented 7 years ago

@eng1neer Did it work with a non-dotted name then?

eng1neer commented 7 years ago

@sagelliv It did, but the project with dotted name was still created in somewhat corrupted state. It refused to load on click with the same error.

ruairif commented 7 years ago

@eng1neer I've updated the PR to disallow project names containing a . thanks for pointing this out