scrapinghub / price-parser

Extract price amount and currency symbol from a raw text string

BSD 3-Clause "New" or "Revised" License

316 stars 50 forks source link

Added two commonly used unofficial currency names (NTD/RMB) #22

Closed starrify closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #22   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          93     95    +2     
  Branches       21     21           
=====================================
+ Hits           93     95    +2

Impacted Files	Coverage Δ
price_parser/_currencies.py	`100% <100%> (ø)`	:arrow_up:

Gallaecio commented 5 years ago

Should we consider adding all of them, since we are at it?

starrify commented 5 years ago

Hi @Gallaecio , thanks for the comment! I thought of this PR earlier when realizing NTD was not part of ISO 4217 (didn't know until 2 days ago). I added only NTD and RMB since I'm familiar with only these two (e.g. seeing them on e-commerce sites). Also the Wikipedia page says something about conflict regarding some other unofficial codes.

kmike commented 5 years ago

Thanks @starrify!