scrapinghub / price-parser

Extract price amount and currency symbol from a raw text string

BSD 3-Clause "New" or "Revised" License

316 stars 50 forks source link

Fix parsing price which contains non-breaking spaces #43

Closed WinterComes closed 4 years ago

WinterComes commented 4 years ago

Fixes #39 This PR contains changes which allow to parse prices with non-breaking space as if it is whitespace

codecov[bot] commented 4 years ago

Codecov Report

Merging #43 (70c682d) into master (7e368bf) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           97        98    +1     
  Branches        21        21           
=========================================
+ Hits            97        98    +1

Impacted Files	Coverage Δ
price_parser/parser.py	`100.00% <100.00%> (ø)`

WinterComes commented 4 years ago

just have to wait the finish of the CI build. It was much faster year ago :slightly_smiling_face:

lopuhin commented 4 years ago

Yeah, the build itself is quite fast, but the queues became larger lately. Thankfully the build passed, merging, thank you!

lopuhin commented 4 years ago

@WinterComes do you think now it's a good time for a release, or you plan any more changes in the near future? Of cause it's not a problem to make more releases later.

WinterComes commented 4 years ago

@WinterComes do you think now it's a good time for a release, or you plan any more changes in the near future? Of cause it's not a problem to make more releases later.

I think it's a good time for a release, thanks @lopuhin

lopuhin commented 4 years ago

0.3.4 is released now 🎉