search

scrapinghub / python-crfsuite

A python binding for crfsuite
MIT License
769 stars 223 forks source link

Add linux aarch64 wheel build support #127

Closed odidev closed 2 years ago

odidev commented 3 years ago

Added linux aarch64 wheel build support. Related to #126 . @kmike Could you please review this PR?

odidev commented 3 years ago

@kmike, Could you please have a look at this PR?

odidev commented 3 years ago

@kmike, Could you please have a look at this PR?

odidev commented 3 years ago

@kmike, Could you please have a look at this PR? Thanks in advance.

fgregg commented 2 years ago

will be superseded by #140

odidev commented 2 years ago

@fgregg The PR mentioned by you did not contain the code for aarch64 wheel build and testing. I have modified the code and the wheel is built and tested successfully on aarch64.

Commit Link: https://github.com/odidev/python-crfsuite/commit/94514e3dcd42122fdd0a694255e537b6135737a0

Github actions Link: https://github.com/odidev/python-crfsuite/runs/6524746640?check_suite_focus=true

If the changes looks good to you. I can raise a PR.

fgregg commented 2 years ago

sure @odidev, let's see a PR!

odidev commented 2 years ago

@fgregg I have raised a PR. Please have a look.