search

scrapinghub / python-crfsuite

A python binding for crfsuite
MIT License
770 stars 222 forks source link

updated crfsuite submodule to include msvc 2015 fix, closes #51 #66

Closed fgregg closed 7 years ago

fgregg commented 7 years ago

This will close #51, #50, #26

fgregg commented 7 years ago

hi @kmike, this is ready for review. All window builds are now passing!!!!!

fgregg commented 7 years ago

the failures in travis are unrelated to this PR

fgregg commented 7 years ago

@kmike I went ahead and made some changes to the travis an manylinux script so now all tests are passing for all configs!

kmike commented 7 years ago

Hey @fgregg,

Thanks a lot, this is super-awesome!

fgregg commented 7 years ago

Great. Can you cut another release for pypi?

kmike commented 7 years ago

@fgregg yep, I was waiting for CI to finish.

fgregg commented 7 years ago

Looks like you might have forgotten to push a tag. That's what triggers pypi uploads.

kmike commented 7 years ago

I have pushed the tag when pushing the commit, you can see it on github (e.g. here) :(