scrapinghub / python-crfsuite

A python binding for crfsuite
MIT License
770 stars 222 forks source link

[MRG] Load tagger from memory #89

Closed lucywang000 closed 6 years ago

lucywang000 commented 6 years ago

Closes #87

Also remove support for python 3.3.

lucywang000 commented 6 years ago

ping @kmike

kmike commented 6 years ago

Thanks @lucywang000, and sorry for a delay! I was unsure how refcounting works in bytes -> char * conversion in Cython, but it seems to work as expected here. Your changes are merged here: https://github.com/scrapinghub/python-crfsuite/pull/95.

lucywang000 commented 6 years ago

Thanks @kmike !