search

scrapinghub / scrapinghub-entrypoint-scrapy

Scrapy entrypoint for Scrapinghub job runner
BSD 3-Clause "New" or "Revised" License
25 stars 16 forks source link

Instantiate pipe_writer even if environment is not set #39

Closed chekunkov closed 7 years ago

chekunkov commented 7 years ago

If pipe path is not set in the environment - replace pipe with a StringIO object and raise a warning.

Alternative to #38

codecov-io commented 7 years ago

Codecov Report

Merging #39 into master will decrease coverage by 0.29%. The diff coverage is 77.77%.

@@          Coverage Diff           @@
##           master   #39     +/-   ##
======================================
- Coverage   98.29%   98%   -0.3%     
======================================
  Files          10    10             
  Lines         644   650      +6     
======================================
+ Hits          633   637      +4     
- Misses         11    13      +2
Impacted Files Coverage Δ
sh_scrapy/writer.py 94.87% <77.77%> (-5.13%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 81465cf...48599e3. Read the comment docs.

chekunkov commented 7 years ago

Discussed with @dangra - decided that #38 is less magical