scrapinghub / scrapinghub-entrypoint-scrapy

Scrapy entrypoint for Scrapinghub job runner
BSD 3-Clause "New" or "Revised" License
25 stars 16 forks source link

Remove use of the deprecated binary parameter of the Python item exporter #71

Closed Gallaecio closed 1 year ago

Gallaecio commented 1 year ago

Needed for the next Scrapy version due to https://github.com/scrapy/scrapy/pull/6007.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a55cc06) 95.53% compared to head (1457278) 95.54%.

:exclamation: Current head 1457278 differs from pull request most recent head c75f5e4. Consider uploading reports for the commit c75f5e4 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #71 +/- ## ======================================= Coverage 95.53% 95.54% ======================================= Files 14 14 Lines 739 740 +1 ======================================= + Hits 706 707 +1 Misses 33 33 ``` | [Files Changed](https://app.codecov.io/gh/scrapinghub/scrapinghub-entrypoint-scrapy/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub) | Coverage Δ | | |---|---|---| | [sh\_scrapy/crawl.py](https://app.codecov.io/gh/scrapinghub/scrapinghub-entrypoint-scrapy/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub#diff-c2hfc2NyYXB5L2NyYXdsLnB5) | `87.14% <100.00%> (+0.28%)` | :arrow_up: | | [sh\_scrapy/extension.py](https://app.codecov.io/gh/scrapinghub/scrapinghub-entrypoint-scrapy/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub#diff-c2hfc2NyYXB5L2V4dGVuc2lvbi5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.