scrapinghub / scrapinghub-entrypoint-scrapy

Scrapy entrypoint for Scrapinghub job runner
BSD 3-Clause "New" or "Revised" License
25 stars 16 forks source link

Spider middlewares are not async compatible #72

Open VMRuiz opened 1 year ago

VMRuiz commented 1 year ago

This library defines several middlewares that are added by default to all jobs running on Scrapycloud. People wanting to use async spider middlewares may face issues as described here

My proposal is to add async compatibility by implementing process_spider_output_async method as per docs to avoid such issues while keeping compatibility with previous versions. Alternatively, they could be converted into fully async middlewares limiting the futures releases of the library to Scrapy >=2.7