Coherent name for AUTOEXTRACT_USER

scrapinghub / scrapy-autoextract

Zyte Automatic Extraction integration for Scrapy

BSD 3-Clause "New" or "Revised" License

55 stars 17 forks source link

Coherent name for AUTOEXTRACT_USER #14

Open ivanprado opened 4 years ago

ivanprado commented 4 years ago

Current names:

scrapy-autoextract -> AUTOEXTRACT_USER scrapinghub-autoextract -> SCRAPINGHUB_AUTOEXTRACT_KEY

It would be nice to be coherent around the different libraries and the API itself. The API seems to use key https://doc.scrapinghub.com/autoextract.html. So probably better to use KEY instead of USER. And then there is a question regarding if using SCRAPINGHUB_AUTOEXTRACT or just AUTOEXTRACT and even if this could be different per library.

victor-torres commented 4 years ago

Thank you for creating this issue, @ivanprado.

My personal suggestion is to rename from AUTOEXTRACT_USER to AUTOEXTRACT_KEY.