search

scrapinghub / scrapy-poet

Page Object pattern for Scrapy
BSD 3-Clause "New" or "Revised" License
119 stars 28 forks source link

ItemProvider always requires Response #150

Closed kmike closed 10 months ago

kmike commented 1 year ago

Currently ItemProvider always requires Response. So, if a page object doesn't need a response, and an item produced by this page object is used as a dependency, then Response is still downloaded.

wRAR commented 1 year ago

As ItemProvider only needs a Response object to pass it to build_instances() we discussed the idea that just passing a DummyResponse instance there can be enough but didn't check that.

Gallaecio commented 10 months ago

Resolved by https://github.com/scrapinghub/scrapy-poet/pull/175