Breaks with Scrapy 2.11

[runa]

After upgrading to Scrapy 2.11 (from 2.10) my scrapyrt API stopped working:

2023-09-18 21:50:50+0000 [scrapyrt] Unhandled Error
    Traceback (most recent call last):
      File "/layers/google.python.pip/pip/lib/python3.11/site-packages/scrapy/crawler.py", line 265, in crawl
        return self._crawl(crawler, *args, **kwargs)
      File "/layers/google.python.pip/pip/lib/python3.11/site-packages/scrapy/crawler.py", line 269, in _crawl
        d = crawler.crawl(*args, **kwargs)
      File "/layers/google.python.pip/pip/lib/python3.11/site-packages/twisted/internet/defer.py", line 1947, in unwindGenerator
        return _cancellableInlineCallbacks(gen)
      File "/layers/google.python.pip/pip/lib/python3.11/site-packages/twisted/internet/defer.py", line 1857, in _cancellableInlineCallbacks
        _inlineCallbacks(None, gen, status, _copy_context())
    --- <exception caught here> ---
      File "/layers/google.python.pip/pip/lib/python3.11/site-packages/twisted/internet/defer.py", line 1697, in _inlineCallbacks
        result = context.run(gen.send, result)
      File "/layers/google.python.pip/pip/lib/python3.11/site-packages/scrapyrt/core.py", line 42, in crawl
        self.engine = self._create_engine()
      File "/layers/google.python.pip/pip/lib/python3.11/site-packages/scrapy/crawler.py", line 172, in _create_engine
        return ExecutionEngine(self, lambda _: self.stop())
      File "/layers/google.python.pip/pip/lib/python3.11/site-packages/scrapy/core/engine.py", line 89, in __init__
        assert crawler.logformatter
    builtins.AssertionError:

Unhandled Error
Traceback (most recent call last):
  File "/layers/google.python.pip/pip/lib/python3.11/site-packages/scrapy/crawler.py", line 265, in crawl
    return self._crawl(crawler, *args, **kwargs)
  File "/layers/google.python.pip/pip/lib/python3.11/site-packages/scrapy/crawler.py", line 269, in _crawl
    d = crawler.crawl(*args, **kwargs)
  File "/layers/google.python.pip/pip/lib/python3.11/site-packages/twisted/internet/defer.py", line 1947, in unwindGenerator
    return _cancellableInlineCallbacks(gen)
  File "/layers/google.python.pip/pip/lib/python3.11/site-packages/twisted/internet/defer.py", line 1857, in _cancellableInlineCallbacks
    _inlineCallbacks(None, gen, status, _copy_context())
--- <exception caught here> ---
  File "/layers/google.python.pip/pip/lib/python3.11/site-packages/twisted/internet/defer.py", line 1697, in _inlineCallbacks
    result = context.run(gen.send, result)
  File "/layers/google.python.pip/pip/lib/python3.11/site-packages/scrapyrt/core.py", line 42, in crawl
    self.engine = self._create_engine()
  File "/layers/google.python.pip/pip/lib/python3.11/site-packages/scrapy/crawler.py", line 172, in _create_engine
    return ExecutionEngine(self, lambda _: self.stop())
  File "/layers/google.python.pip/pip/lib/python3.11/site-packages/scrapy/core/engine.py", line 89, in __init__
    assert crawler.logformatter
builtins.AssertionError:

[michaelbrunnbauer]

same here

[pawelmhm]

thanks for report, some backward incompatible changes in scrapy crwaler object: https://docs.scrapy.org/en/latest/news.html#backward-incompatible-changes will check that

[runa]

Thanks! if you need details or anything please let me know.

On Tue, Sep 19, 2023 at 2:23 AM Paweł Miech @.***> wrote:

thanks for report, some backward incompatible changes in scrapy crwaler object: https://docs.scrapy.org/en/latest/news.html#backward-incompatible-changes will check that

— Reply to this email directly, view it on GitHub https://github.com/scrapinghub/scrapyrt/issues/152#issuecomment-1724847875, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAOECUNAXO3U3G4WHXGPCLX3ET3PANCNFSM6AAAAAA45L263A . You are receiving this because you authored the thread.Message ID: @.***>

-- Martin Sarsale http://www.linkedin.com/in/msarsale

[pawelmhm]

released to pypi