search

scrapinghub / shub-workflow

BSD 3-Clause "New" or "Revised" License
13 stars 14 forks source link

Fix dependency conflict #1

Closed BurnzZ closed 5 years ago

BurnzZ commented 5 years ago

Hi @kalessin

It would seem that the commit in https://github.com/scrapinghub/shub-workflow/commit/9d0684c236934186a030f5bd1a606faf95f0f488 have broke our builds due to the some dependency conflicts described below:

- shub-workflow [required: >=1.5.1]
  - botocore [required: ==1.12.91]
  - s3fs [required: ==0.2.0]
    - boto3 [required: Any]
      - botocore [required: >=1.12.92,<1.13.0]

As can be seen from the dependency graph above, botocore from shub-workflow should be bumped to at least 1.12.92 in order to match the botocore >=1.12.92,<1.13.0 that is required for boto3.

This PR intends to bump the botocore version to prevent such dependency conflicts.

I've also updated the version of this package so we could release this as soon as possible.

Please let me know if I could assist in some steps.

Cheers!

kalessin commented 5 years ago

Until yesterday the last botocore version was 1.12.91. I see there was a new release of boto3 and botocore in the last hours. The origin of the problem is that s3fs doesn't fix the version of boto3 and botocore, and so if there is already boto3 and botocore installed, old versions became installed, and I found an issue on an old version of botocore.

I suspect that if we only change the required version of botocore, we will soon have the same issue again (and probably many people will have this issue even without an update of boto3). I think it is better to pin to boto3>=1.9.92 instead, and remove botocore requirement. I will close this PR and do that change instead.

Thanks for pointing out the issue!