search

scrapinghub / shub-workflow

BSD 3-Clause "New" or "Revised" License
13 stars 14 forks source link

Extend pyyaml supported versions #26

Closed curita closed 2 years ago

curita commented 2 years ago

pyyaml version is pinned between 3.12 and 5.3.1.

But testing locally the version 5.4.1 looks to be also supported.

5.4.1 is the version right before 6.0. 6.0 changes how yaml.load() is called so it needs explicit support (https://github.com/scrapinghub/shub-workflow/issues/22), but 5.4.1 can be supported as it is.

Supporting this version would allow shub-workflow to be used with the latest ScrapyCloud Scrapy stacks without dependency conflicts.

kalessin commented 2 years ago

Hi Julia! Thanks for the patch.

I just added into master the setup for running automated tests. That also included the reformatting of many lines, including lines in the setup.py file. Can you rebase your branch and resolve the conflicts? Thanks!

curita commented 2 years ago

Absolutely, thanks for checking in!

kalessin commented 2 years ago

Merged. Thanks for the patch!