scrapinghub / shub-workflow

BSD 3-Clause "New" or "Revised" License
13 stars 14 forks source link

suggestion: Reduce log level of "Failed to schedule job" messages #54

Open curita opened 8 months ago

curita commented 8 months ago

Background

Sometimes shub-workflow fails to schedule a job and retries the action until it succeeds or runs out of attempts.

In those situations, those "Failed to schedule job" messages will be reported as Errors, even though they don't require user actions other than waiting for those retries to finish.

Proposal

It would be nice for these messages to be considered warnings: https://github.com/scrapinghub/shub-workflow/blob/50c85fedee887b2552fd43343692b3e5192bfd09/shub_workflow/script.py#L388

So they aren't flagged by monitors supervising log messages. If all retries made by @dash_retry_decorator fail, then the original issue is reraised, which seems to be reported as an error already.