Don't import non-integer project names

scrapinghub / shub

Scrapinghub Command Line Client

https://shub.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

125 stars 79 forks source link

Don't import non-integer project names #149

Closed jdemaeyer closed 8 years ago

jdemaeyer commented 8 years ago

scrapy startproject myprojectname puts the following section into scrapy.cfg:

[deploy]
project = myprojectname

When users first run shub deploy, this will be transferred to scrapinghub.yml and an error message will be printed.

We should not import non-integer project names from scrapy.cfg and instead guide users through the deploy wizard.

jdemaeyer commented 8 years ago

This is a big user-friendliness issue. Any user that follows our instructions on the Deploy page will run into an error message instead of into the deploy onboarding wizard.

pablohoffman commented 8 years ago

Completely agree @jdemaeyer, can you send a pull request to Scrapy?

jdemaeyer commented 8 years ago

Will do. I think this is primarily a shub issue though (after all scrapyd has no problems with alphanumeric project names), I'm working on a patch right now and would opt for doing a quick 2.0.2 release when it's merged.