search

scrapinghub / shublang

Pluggable DSL that uses pipes to perform a series of linear transformations to extract data
BSD 3-Clause "New" or "Revised" License
15 stars 8 forks source link

add tox config to test Python 3.5 to 3.8 #45

Open BurnzZ opened 4 years ago

BurnzZ commented 4 years ago

@akshayphilar I'm adding some tox configs since we need to ensure that the new functionalities we will be implementing in https://github.com/scrapinghub/shublang/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22 correctly runs across different Python 3 versions.

@jsargiot, I'm quite unfamiliar with CircleCI as SH uses Travis CI in majority of its repos. Could you review if I'm invoking tox correctly?

For Travis CI, we usually configure it via https://github.com/scrapy/itemloaders/blob/master/.travis.yml#L8-L23 which results in https://travis-ci.com/github/scrapy/itemloaders/builds/178576103, testing across the declared Python environments.

EDIT: Looks like the new tox config correctly runs in Circle CI as can be seen in this build. However, it would seem that some of the Python envs are not setup yet in it.

image

Thanks!

jsargiot commented 4 years ago

It seems this is the best approach to have different python versions: https://ben.fogbutter.com/2016/02/20/testing-multiple-python-versions-on-circleci.html