Fix bot breaking when new users join groups/the team

scrapinghub / slackbot

A chat bot for Slack (https://slack.com).

MIT License

1.26k stars 396 forks source link

Fix bot breaking when new users join groups/the team #141

Closed StewPoll closed 7 years ago

StewPoll commented 7 years ago

This is a resurrection of #117, which was designed to fix the problems with #115 and #61

Test coverage should be possible. I'm not sure exactly what tests you'd want though. This lives within the MessageDispatcher classes loop function, but it primarily relies on SlackClient for actual functionality, so if anything a test for parse_channel_data should be done.

StewPoll commented 7 years ago

When it comes to testing it, a similar approach is used in the slackrtm library. This is then used by the Limbo slack bot.

tehranian commented 7 years ago

Thanks guys for fixing this! When are you planning to ship a release to PyPI?

jtatum commented 7 years ago

@tehranian, I haven't heard from @lins05 in a while, but I think I can cut a release. I still want to add some tests for this code, and I need to make a changelog. Maybe next weekend? In the meantime, feel free to use setup.py install to install the version from the develop branch on github.