search

scrapinghub / slackbot

A chat bot for Slack (https://slack.com).
MIT License
1.26k stars 394 forks source link

Finished updates for private group/channel terminology changes #160

Closed DannyHinshaw closed 7 years ago

DannyHinshaw commented 7 years ago

Issue Ref: #93

Main Issue: Slack changed their terminology for 'private groups' to 'private channels'. However, there are still 'groups', but only for paid accounts. This change in terminology has caused some confusion.

Changes: Most all changes were made in the testing architecture, with a few changes in the CONTRIBUTING.md as well (for slackbot_test_settings.py setup)

Also included in these changes is a backwards compatibility patch for TravisCI where environment variables may still be using the outdated 'SLACKBOT_TEST_GROUP'.

Tests: All tests for this PR passed for me both locally and with TravisCI (including testing backwards compat. for 'SLACKBOT_TEST_GROUP' env var)

Signed-off-by: Danny danny@nulleffort.com

DannyHinshaw commented 7 years ago

Made the requested changes, hopefully good to go now.

jtatum commented 7 years ago

Thanks again for your contribution!

DannyHinshaw commented 7 years ago

Absolutely, thank you for all your work on this!