Make rmt_connect() calling proper

scrapinghub / slackbot

A chat bot for Slack (https://slack.com).

MIT License

1.26k stars 394 forks source link

Make rmt_connect() calling proper #163

Closed takegue closed 6 years ago

takegue commented 7 years ago

SlackClient calls rtm_connect() on its instantiation. That's why the code will cause 429 Error like #162

ye commented 6 years ago

We experienced this type of downward spiral loop today as well. It started with Slack responding a 503 error (server temporarily unavailable) and quick enough we started to get HTTP 429 errors due to the unconditional reconnect logic and caused the Slack RTM API rate limits being hit (1 request/second sustaining).

@lins05 can you review and merge this patch?

hadim commented 6 years ago

Could this be merged, please?