search

scrapinghub / slackbot

A chat bot for Slack (https://slack.com).
MIT License
1.26k stars 396 forks source link

Update default threading behavior #172

Closed jonas-schulze closed 6 years ago

jonas-schulze commented 6 years ago

If a message was sent in a thread, answer in a thread per default.

jsargiot commented 6 years ago

Hey! Looks good, how about adding a test for this? That would help merging it faster. Thanks!

jonas-schulze commented 6 years ago

Hey @jsargiot, thanks for the response. I won't make it to create a custom testing instance of Slack nor configure Travis. It would be way easier for me (and everybody else who wants to contribute), if you could setup your Travis to run all the tests. If you are concerned about users that are not that familiar with git and that add several commits just to fix test errors, you could automatically squash all commits of a PR.

jonas-schulze commented 6 years ago

Have you read https://docs.travis-ci.com/user/pull-requests/?