search

scrapinghub / slackbot

A chat bot for Slack (https://slack.com).
MIT License
1.26k stars 396 forks source link

websocket-client version upgrade #201

Open hadim opened 4 years ago

hadim commented 4 years ago

Any reason why the websocket-client version is stuck at 0.44? The current version is 0.56. How hard would it take to upgrade slackbot to 0.56?

lucywang000 commented 4 years ago

what feature do you want from 0.56?

hadim commented 4 years ago

None. It's just having an old version could conflict with others dependencies at some point for the conda package: https://github.com/conda-forge/slackbot-feedstock/blob/c7018b3a8e6d995ba53e07cffc3a83dc2ff4bc0e/recipe/meta.yaml#L23

So far there is no issue, I am just trying to anticipate.

bsima commented 4 years ago

One reason to want a version >0.44 would be to get this feature, which seems pretty useful: https://github.com/websocket-client/websocket-client/pull/415