search

scrapinghub / slackbot

A chat bot for Slack (https://slack.com).
MIT License
1.26k stars 395 forks source link

PROPOSAL: Slackbot settings when bot is instanced #52

Closed merqurio closed 8 years ago

merqurio commented 8 years ago

We wanted to create more than a bot, different instances. Right now all the settings of the bot are defined in the slackbot_settings.pyfiles, but I think that a more intuitive implementation would be to pass thos configurations as attributes of the class instantiation.

bot = Bot(api_token="<your-api-token>",
          plugins_dir="your_plugins_directory/"
          default_reply=<my_func or str>)
merqurio commented 8 years ago

I would gladly do the PR on that :+1:

lins05 commented 8 years ago

SGTM!

merqurio commented 8 years ago

Great, expect a PR for next week !

chris-skud commented 8 years ago

Is this in motion? And to confirm, would this enable launching the bot into multiple Slack teams from single bot process? Like Botkt's ability to spawn teams by token?

If so, a big :+1: .

Thanks!

merqurio commented 8 years ago

I'm on it, and I think yes, you could be able to get two bot's but each one on it's own thread https://github.com/lins05/slackbot/blob/develop/slackbot/bot.py#L32 as far as I understand, but sure @lins05 knows better than me !

On Thu, Mar 3, 2016 at 5:37 AM Chris Skudlarczyk notifications@github.com wrote:

Is this in motion? And to confirm, would this enable launching the bot into multiple Slack teams from single bot process? Like Botkt's ability to spawn teams by token https://github.com/howdyai/botkit/blob/febbd176fe6926a8211938f71b7c6217a0f90531/bot.js#L79?

If so, a big [image: :+1:] .

Thanks!

— Reply to this email directly or view it on GitHub https://github.com/lins05/slackbot/issues/52#issuecomment-191578209.

chris-skud commented 8 years ago

thx!

thekantian commented 8 years ago

Just a ping here - this would be a big win to get in there for me - would be happy to help out if at all possible - is there a branch towards this feature yet?

merqurio commented 8 years ago

WIP, nothing clear yet, if you start a branch I'll gladly help you :grin:

On Tue, Mar 22, 2016 at 2:22 AM Zachary Zaro notifications@github.com wrote:

Just a ping here - this would be a big win to get in there for me - would be happy to help out if at all possible - is there a branch towards this feature yet?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/lins05/slackbot/issues/52#issuecomment-199571277

merqurio commented 8 years ago

There it is @thekantian

thekantian commented 8 years ago

Wow, too fast! Will take a look @merqurio that's awesome...