Closes #52 and suggested modifications added

scrapinghub / slackbot

A chat bot for Slack (https://slack.com).

MIT License

1.26k stars 395 forks source link

Closes #52 and suggested modifications added #66

Closed merqurio closed 8 years ago

merqurio commented 8 years ago

README.md:

Update to reflect modifications in default_reply function
Suggestions by @lins05

slackbot/bot.py:

Remove logging settings

slackbot/dispatcher.py:

Restructure _default_reply()

merqurio commented 8 years ago

Sorry I opened a new PR But I was unable to squash both commits and maintain the same PR :disappointed:

lins05 commented 8 years ago

The code lgtm, can you also add tests for this new feature?

lins05 commented 8 years ago

Also the commit message is toooo long, can you replace it with one or two short sentences?

jtatum commented 8 years ago

Is slackbot/settings.py still needed? This will probably break tests, especially on travis - see tests/functional/slackbot_settings.py. Does run.py still work after this change? Do tests pass?

merqurio commented 8 years ago

I'm working on the tests, sorry I forgot to tell you that @jtatum