search

scrapinghub / slackbot

A chat bot for Slack (https://slack.com).
MIT License
1.26k stars 396 forks source link

worker threads pool #8

Open lins05 opened 9 years ago

lins05 commented 9 years ago

Currently slackbot would spawn 10 worker threads on startup, this is ugly. It should only create new worker threads when needed, and make sure the max number of worker threads is not exceeded.

sinwoobang commented 8 years ago

Hi, @lins05

My project using this library raises 429 http error. Slack api docs say they respond with 429 just when clients requests exceed one message per second.

Is this error raised by this issue?

Thanks.

lins05 commented 8 years ago

@sinwoobang I don't think they are related. What were you requesting when slack api returns 429 to you?

sinwoobang commented 8 years ago

@lins05

I did request with just 3 methods.

2 methods using respond_to. 1 method using listen_to.

Each methods are just one line.

sinwoobang commented 8 years ago

It is resolved. I guess the reason was what I executed on server and local at the same time.