search

scrapinghub / slackbot

A chat bot for Slack (https://slack.com).
MIT License
1.26k stars 394 forks source link

Adding capability to run in background and send messages. #89

Closed cristianowa closed 3 years ago

cristianowa commented 8 years ago

With the intent to provide a better interface for doing things like the #42 I made a modification so, if needed, the bot can be executed in background and can be used to send messages still. Based on that one can do the cron execute after it and just call bot.send_message().

For doing that I moved the loop from the dispatcher to to the bot and created a thread if it was running on background.

If used with default parameters, the behavior remains the same.

jtatum commented 7 years ago

This is a pretty major change to the behavior of the bot. In particular, it seems to remove the thread pool by default. Can you document some use cases? Might be nice to compare this approach to the one taken in #95. Is there any way to test this change?

lins05 commented 7 years ago

ping @cristianowa

cristianowa commented 3 years ago

Closing this since has been a while.