search

scrapinghub / slackbot

A chat bot for Slack (https://slack.com).
MIT License
1.26k stars 394 forks source link

Skip group tests if group is not set #93

Closed csaftoiu closed 8 years ago

csaftoiu commented 8 years ago

Slack apparently requires you to pay money now to create a user group. This means creating a new Slack just to test the bot is unwieldy.

I simply made it skip the group tests if the test_group is falsy.

lins05 commented 8 years ago

Slack apparently requires you to pay money now to create a user group

Really? I can still create private groups in a free slack team.

csaftoiu commented 8 years ago

Ohh is "private group" === "private channel"? That would have saved me some time :).

http://venturebeat.com/2015/10/27/slack-launches-group-chats-turn-private-groups-into-private-channels/

Mind if I make a new PR which re-names it in that case?

DannyHinshaw commented 7 years ago

I understand this issue is closed, but a definitive answer was never stated, only as in the form of a question from from @csaftoiu

Ohh is "private group" === "private channel"?

Yes, apparently it is. This caused confusion for me as well hopefully this comment will help others know ahead of time. I would also be in favor of a renaming, or at the least make this distinction clearer in the documentation. I don't mind submitting the changes personally since it looks like this was never followed through on (as far as I can tell).

Great framework though guys, glad I happened upon it.

jtatum commented 6 years ago

@DannyHinshaw The folks at slack renamed private groups to private channels at the end of 2015. A pull request to catch our testing infrastructure up with the change would be most welcome :) Even better, if the code could handle an env var named SLACKBOT_PRIVATE_CHANNEL if present, falling back to SLACKBOT_PRIVATE_GROUP, that'd be neat since there's more than a few of us with travis setup and this kind of change takes a while to propagate.

DannyHinshaw commented 6 years ago

@jtatum , cool you got it. I'll be starting on this today since I was planning on doing some plugin work anyways. Slack also just updated their terminology for 'Teams', we're 'WorkSpaces' now... rolls eyes. Think I'll save looking into that for another time

Edit: PR Submitted