scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
527 stars 96 forks source link

Create tests for PythonExpressionsMonitor #101

Open rennerocha opened 5 years ago

rennerocha commented 5 years ago

This feature is not tested: https://github.com/scrapinghub/spidermon/blob/master/spidermon/python/factory.py#L12

rennerocha commented 5 years ago

89 happened because the lack of tests of this class.

leovictorsr commented 5 years ago

@rennerocha I started to work on this issue and I have a simple question. As a factory of python expression monitors, the tests for this feature should be under the test_monitors class, or it would be good to have it in a different class for clarity (as test_monitors tests refer to built-in scrapy monitors).

Also, could you give me a simple example of expression we are expected to receive to be monitored?

rosheen33 commented 5 years ago

https://github.com/scrapinghub/spidermon/blob/master/tests/contrib/scrapy/test_extensions.py

mirceachira commented 4 years ago

Is this still relevant&available? I'd like to work this if possible