search

scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
533 stars 97 forks source link

Add default template to email actions #125

Closed matiskay closed 5 years ago

matiskay commented 5 years ago

It would be great to use reports/email/monitors/result.jinja as the default template for SPIDERMON_BODY_HTML_TEMPLATE.

vipulgupta2048 commented 5 years ago

I would like to take this up. I think this could be the right place to have this in the file https://github.com/scrapinghub/spidermon/blob/bf51f3381ac01dc7b85032f34c3686a94a5c9b46/spidermon/contrib/actions/email/__init__.py#L84 

"body_text_template": crawler.settings.get("SPIDERMON_BODY_TEXT_TEMPLATE") or `Path/to/result.jinja` ,

In reference to: https://github.com/scrapinghub/spidermon/blob/master/spidermon/contrib/actions/reports/templates/reports/email/monitors/result.jinja

CC: @matiskay @rennerocha @raphapassini

rosheen33 commented 5 years ago

171

rosheen33 commented 5 years ago

PR is merged

rosheen33 commented 5 years ago

@rennerocha @raphapassini PR is merged I am going to close this issue.