scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
533 stars 97 forks source link

Update list settings to use settings.getlist #210

Closed ejulio closed 4 years ago

ejulio commented 5 years ago

Some list-like settings, SPIDERMON_EMAIL_TO for example, are loaded using settings.get. Then, they need to be formatted properly. By updating to getlist the method is not required, as it is always a list, so we only need to join the value.

I suggest to start using settings.getlist as it is standard across scrapy and we can follow conventions for it.

rennerocha commented 4 years ago

Fixed in https://github.com/scrapinghub/spidermon/pull/238.