search

scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
533 stars 97 forks source link

Update slackclient to v2.0 #265

Closed andersonberg closed 4 years ago

andersonberg commented 4 years ago

This PR fixes https://github.com/scrapinghub/spidermon/issues/251 Updating the slackclient to the new version. Requirements and setup were updated to use slackclient versions higher than 2.0. I also updated tests and docs.

codecov[bot] commented 4 years ago

Codecov Report

Merging #265 into master will increase coverage by 1.13%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   72.52%   73.66%   +1.13%     
==========================================
  Files          68       68              
  Lines        2817     2954     +137     
  Branches      321      319       -2     
==========================================
+ Hits         2043     2176     +133     
- Misses        712      717       +5     
+ Partials       62       61       -1
Impacted Files Coverage Δ
spidermon/contrib/actions/slack/__init__.py 50.00% <66.66%> (-0.91%) :arrow_down:
spidermon/contrib/actions/email/ses.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/jobs/tags.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/reports/s3.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/reports/files.py 0.00% <0.00%> (ø)
spidermon/contrib/monitors/mixins/stats.py 100.00% <0.00%> (ø)
spidermon/contrib/actions/sentry/__init__.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/slack/notifiers.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/reports/__init__.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/telegram/notifiers.py 0.00% <0.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2154b29...c86a376. Read the comment docs.