Closed anapaulagomes closed 2 years ago
Merging #280 (205c303) into master (f2b21e4) will decrease coverage by
0.53%
. The diff coverage is48.43%
.
@@ Coverage Diff @@
## master #280 +/- ##
==========================================
- Coverage 74.21% 73.68% -0.54%
==========================================
Files 68 70 +2
Lines 3033 3097 +64
Branches 462 471 +9
==========================================
+ Hits 2251 2282 +31
- Misses 719 752 +33
Partials 63 63
Impacted Files | Coverage Δ | |
---|---|---|
spidermon/contrib/actions/discord/notifiers.py | 0.00% <0.00%> (ø) |
|
spidermon/contrib/actions/discord/__init__.py | 75.60% <75.60%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f2b21e4...205c303. Read the comment docs.
The build is failing due to a formatting issue that isn't related to this PR. How should I proceed?
Any news here @rennerocha?
Hey guys, this PR could add a very useful feature to this project. There are any intention to accept this suggestion for the project?
Yes, we want this PR to be merged as soon as possible. Probably it will be available in our next release.
I am working at this :)
This feature will be finished in https://github.com/scrapinghub/spidermon/pull/348
Add Discord integration. To test it you'll need two environment variables:
SPIDERMON_DISCORD_WEBHOOK_URL
andSPIDERMON_DISCORD_FAKE
. See how to get a discord webhook URL here.Checklist: