search

scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
533 stars 97 forks source link

[PeriodicExecutionTimeMonitor] Creating monitor for runtime exceeding a target maximum #309

Closed further-reading closed 2 years ago

further-reading commented 3 years ago

fixes https://github.com/scrapinghub/spidermon/issues/300

rennerocha commented 3 years ago

@further-reading looks good. Need some unit tests.

codecov[bot] commented 3 years ago

Codecov Report

Merging #309 (240cc2f) into master (1e098e4) will increase coverage by 0.17%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
+ Coverage   74.04%   74.21%   +0.17%     
==========================================
  Files          68       68              
  Lines        3013     3033      +20     
  Branches      458      462       +4     
==========================================
+ Hits         2231     2251      +20     
  Misses        719      719              
  Partials       63       63
Impacted Files Coverage Δ
spidermon/contrib/scrapy/monitors.py 98.26% <100.00%> (+0.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1e098e4...240cc2f. Read the comment docs.