search

scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
528 stars 96 forks source link

Replace slackclient with slack-sdk for Slack action #313

Closed rennerocha closed 2 years ago

rennerocha commented 2 years ago

slackclient is under maintenance mode, being replaced by slack-sdk library. Considering that this is a Spidermon third-party integration that is used by so many projects and that Slack can change their APIs without us even noticing it, it would be good if we keep our library as much updated as possible with theirs.

ankitjavalkar commented 2 years ago

I'll be working on this issue.

I see the slack documentation provides a few suggestions for migrations here, will these suggested changes be sufficient?

rennerocha commented 2 years ago

I'll be working on this issue.

I see the slack documentation provides a few suggestions for migrations here, will these suggested changes be sufficient?

Apparently this change is simple like that.

rennerocha commented 2 years ago

Fixed by https://github.com/scrapinghub/spidermon/pull/338