search

scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
528 stars 96 forks source link

Remove use of private module from jsonschema #315

Closed rennerocha closed 1 year ago

rennerocha commented 2 years ago

jsonschema latest version removed jsonschema.compat module. According to its author, this module was intended to be private and not used by external users.

We are using this module in some JSON Schema custom validators, and I received reports from users that had problems with it.

Considering that jsonschema.compat was created just for compatibility with older Python version, and that we don't have this requirement anymore, we should update there to avoid this issue when using the newest version of the library.

aaneto commented 1 year ago

Hi @rennerocha!

I have started a local fork of the repository and would like to work on this issue :)

aaneto commented 1 year ago

Hi,

I'm closing this as this issue was fixed in #364 :)