search

scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
528 stars 96 forks source link

Slack Code update #332

Closed further-reading closed 2 years ago

further-reading commented 2 years ago

Updating slack docs to explain the options and fixing issues with overwriting default settings.

The issue was that the old version was something like "default or value_from_settings" so if default is true and value_from_settings is false it would be True or False and thus always True. This new one doesn't use getbool to retrieve the value from settings so it can be True, False or None and will use this value when it is not None.

codecov[bot] commented 2 years ago

Codecov Report

Merging #332 (85fdb10) into master (06d70af) will decrease coverage by 0.09%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   74.20%   74.11%   -0.10%     
==========================================
  Files          68       68              
  Lines        3032     3036       +4     
  Branches      462      466       +4     
==========================================
  Hits         2250     2250              
- Misses        719      723       +4     
  Partials       63       63
Impacted Files Coverage Δ
spidermon/contrib/actions/slack/__init__.py 56.63% <0.00%> (-1.03%) :arrow_down:
spidermon/contrib/actions/slack/notifiers.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 06d70af...85fdb10. Read the comment docs.