search

scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
528 stars 96 forks source link

[PeriodicExecutionTimeMonitor] Using utcnow and comparing to spider start as dt #333

Closed further-reading closed 2 years ago

further-reading commented 2 years ago

Fixing issue where it checks unix timestamp instead of datetime retrieved via utcnow. Reported in original PR after merge - https://github.com/scrapinghub/spidermon/pull/309

codecov[bot] commented 2 years ago

Codecov Report

Merging #333 (bc63c2f) into master (f2b21e4) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   74.21%   74.20%   -0.01%     
==========================================
  Files          68       68              
  Lines        3033     3032       -1     
  Branches      462      462              
==========================================
- Hits         2251     2250       -1     
  Misses        719      719              
  Partials       63       63
Impacted Files Coverage Δ
spidermon/contrib/scrapy/monitors.py 98.25% <100.00%> (-0.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f2b21e4...bc63c2f. Read the comment docs.